fix(cbor): incorrect decoding with subarrays #6344
Merged
+34
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6344 +/- ##
==========================================
- Coverage 96.40% 96.40% -0.01%
==========================================
Files 549 549
Lines 41841 41841
Branches 6350 6350
==========================================
- Hits 40337 40336 -1
- Misses 1464 1465 +1
Partials 40 40 ☔ View full report in Codecov by Sentry. |
|
The fix looks good, but how about passing byteOffset and byteLength to DataView constructor instead? |
|
That is probably better. I didn't even realise that was an option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a simple bug in the event a subarray is passed into
decodeCborwhich would cause data to be incorrectly decoded and/or throw an error.