Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs/unstable): add symlink and symlinkSync #6352

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

jbronder
Copy link
Contributor

This PR adds the symlink and symlinkSync APIs to @std/fs, which are functions intended to mirror Deno.symlink and Deno.symlinkSync, respectively. The PR also adds the associated SymlinkOptions type.

Towards #6255.

@jbronder jbronder requested a review from kt3k as a code owner January 20, 2025 06:52
@github-actions github-actions bot added the fs label Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 55.26316% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.33%. Comparing base (5d41054) to head (0d53a6d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
fs/unstable_symlink.ts 55.26% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6352      +/-   ##
==========================================
- Coverage   96.37%   96.33%   -0.05%     
==========================================
  Files         550      551       +1     
  Lines       41880    41918      +38     
  Branches     6351     6353       +2     
==========================================
+ Hits        40363    40380      +17     
- Misses       1477     1498      +21     
  Partials       40       40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work! Thanks

@kt3k kt3k merged commit a2a6305 into denoland:main Jan 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants