Bugfix / Inconsistency: Respect Uint8Array offsets #826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, so found a potential bug in std:
This PR should only affect varnum() and friends operating on Uint8Array subarrays where the offset is > 0.
I replaced all hardcoded 0 indices in the relevant functions with b.byteOffset to get the desired behavior of logging 5 in the above example.
I also added a test for my change (note that this only tests varnum, and not all the relevant functions).