Implement renaming symbols via LSP and tsserver

[w0rp]

LSP and tsserver support operations for renaming things, and ALE should support these operations.

[wavded]

This would be super handy to have. Any plans still @w0rp ? I would prefer to just use ale than have another lang server plugin that supports this.

[w0rp]

The plan is to just eventually implement it somehow.

[eugene-bright]

LanguageClient-neovim implements this feature. It's a subject to some 'code sharing'.
autozimu/LanguageClient-neovim#35 (comment)

[w0rp]

It sure does. It's not ALE. I'll implement this eventually, or someone else can try.

[eugene-bright]

May we get the feature by low price by passing LSP connection to LanguageClient-neovim functions? Raw ugly but possible working idea.

[w0rp]

Sure, I already implemented support so that other tools can give diagnostics to ALE, for ALE to render. See :help ale-lint-other-sources. Someone can either add support for ALE to LanguageClient-neovim, or someone can implement a plugin that bridges the two. ALE itself won't ever implement support for some other language server plugin, and it doesn't have to.

[mwilliammyers]

I have an old commit that adds support for the lsp and tsserver renaming protocols and (most likely not working) support for performing the actual renaming in vim.

I can open a work in progress PR (I most likely won't have a ton of time to work on this for a while...) or someone is welcome to use my commit as a basis to finish it off.

[w0rp]

Thank you for sharing that. Someone might pick it up and finish the job. 👍

[Risto-Stevcev]

I tried getting this to work a while back but it doesn't seem to rename anything:
Risto-Stevcev@a94bf9b

This is such a critical IDE feature, it would be nice to get this in

[jeremija]

I made rename work for TypeScript by continuing off of @mwilliammyers's work (thanks!). It's on my fork on the feature/renaming-symbols branch. Here's the link to the main commit. I also merged upstream/master into it to keep it up to date.

Since I changed the message structure in ale#rename#HandleTSServerResponse (that eventually gets passed on to s:ApplyRenameEdits), it also needs to be changed in ale#rename#HandleLSPResponse.

Also, the way the buffer contents get replaced seems hackish as hell - I'd appreciate if somebody could suggest a better way to do it :)

[w0rp]

:ALERename has been merged already now.