-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #35
Comments
Use |
Default
|
New Configuration:
|
vim support is added in #151. |
Announcement and Breaking ChangesMaster branch is deprecated. Please switch to branch next if possible. All of the functionalities should behave exactly as previously, only
File an issue if it isn't the case. Default branch is set to next. So new installation will be using branch next by default. |
This is awesome that you no longer rely on python! I did notice that you download upon install. That's going to make it hard to use this within certain corporate settings. Is it possible for you to make releases that have the necessary binaries included within them? (Vim Plug allows specifying a branch/release I believe). |
The main concern is that committing in binary blobs will explode the repo pretty quickly. Besides the install script, there are also two alternatives,
Not sure if this answers your question. And let me know if there are any better solutions. |
You can have the master branch download on the fly when you install the master branch, but then you can also publish versions of the plugin that have the prebuilt artifacts inside the repo, in your "releases" page. Vim-plug should also allow depending on releases as well. I think you do so like this:
That would give corporate users the option of just depending on the tagged release for their platform. I think it would actually be better for most users (even outside of corporate environments) |
Could someone somewhere explain why there was a switch to the rust solution compared to python? I can imaging some people are also unhappy about downloading "random" binary blobs that they did not verify. Maybe adding a "manual-install.sh" file as an alternative to call in vim-plug etc, which compiles from source, documented in the readme, would also be a nice option. |
I would suggest two modes: |
Note added to build locally. 379d42e |
As I mentioned before, if we commit in binary blobs into repo, since every release (combining every platforms) is 20Mb, with 50 releases, they are going to be 1Gb increase of repo size, which I believe is not a practical thing. |
You only really need to keep the most recent |
It's not possible to delete blobs from the repo once you've pushed them. They stay part of the git history forever. |
@tbodt are you sure about that? I believe you can delete their tags, which orphans them. Doesn't github have some kind of a collection process? |
@jordwalke not if the commits are still reachable, which they would be if this was done the obvious way |
New function LanguageClient-neovim/doc/LanguageClient.txt Lines 553 to 556 in 5e96854
|
This comment has been minimized.
This comment has been minimized.
New function LanguageClient-neovim/doc/LanguageClient.txt Lines 567 to 570 in 542203b
|
This comment has been minimized.
This comment has been minimized.
|
Event |
Neovim virtual text is supported. Of course with option to turn it off if you'd like LanguageClient-neovim/doc/LanguageClient.txt Lines 343 to 348 in 273e5dc
To customize the highlight group to use for virtual text, LanguageClient-neovim/doc/LanguageClient.txt Line 103 in 273e5dc
|
Hover content will be displayed in a floating window whenever possible (implemented in neovim 0.4.0). Thanks to @rhysd. Call hover twice to switch into the floating window. If you want to disable this behaviour, LanguageClient-neovim/doc/LanguageClient.txt Lines 350 to 358 in c33c45d
For more details, see #767 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Release 0.1.156 contains breaking changes regarding setting LanguageClient-neovim/doc/LanguageClient.txt Lines 343 to 348 in fb02afe
|
(For update announcements only, please refrain from off-topic comments.)
The text was updated successfully, but these errors were encountered: