Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rails 7.1.3 -> 7.2.2 #19716

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Bump Rails 7.1.3 -> 7.2.2 #19716

merged 7 commits into from
Dec 10, 2024

Conversation

ryan-mcneil
Copy link
Contributor

@ryan-mcneil ryan-mcneil commented Dec 4, 2024

Summary

  • Bump Rails 7.1.3 -> 7.2.2

Note: Issues with ruby 3.3.3 caused the net-pop dependency to not be properly included. Bumping to 3.3.4+ and bundling reintroduced the missing dependency. more here and here

Related Issue(s)

@va-vfs-bot va-vfs-bot temporarily deployed to rm-bump-rails-7.2.2/main/main December 6, 2024 17:35 Inactive
@ryan-mcneil ryan-mcneil requested a review from a team as a code owner December 9, 2024 23:13
@ryan-mcneil ryan-mcneil requested review from a team as code owners December 9, 2024 23:56
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/schema_contract/validation.rb

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: app/models/schema_contract/validation.rb

@ryan-mcneil ryan-mcneil merged commit 5b10536 into master Dec 10, 2024
17 checks passed
@ryan-mcneil ryan-mcneil deleted the rm-bump-rails-7.2.2 branch December 10, 2024 18:18
@jerekshoe
Copy link
Contributor

I'm noticing an interesting change introduced by the rails update. It appears that it changes the way that config.filter_parameters works in the rails console as previously you could view the attributes and their values for ActiveRecord models, but now I get FILTERED for all of the values. I tried this commit 868addfe4be2856c190f6d7c718f3767b7120260 (the one right before this one) and I see this when I call EVSSClaims.all on my local rails instance
Screenshot 2024-12-11 at 10 26 06 PM

But after this PR I see this:
Screenshot 2024-12-11 at 10 31 36 PM

Since most devs don't have access to RDS this kinda makes it difficult to query DB records. Not sure if there is a configuration option to make it work the old way as it doesn't seem feasible to add all of the DB columns to the list in config/initializers/filter_parameter_logging.rb (I found that adding evss_claim_id to the list made it not show up as filtered anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants