Add CustomEvent polyfill from Mozilla docs #17095
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a polyfill for
CustomEvent
since it isn't supported natively in IE11. This API is necessary for the analytics coming fromcomponent-library
components.The polyfill was copy-pasted with light modifications from https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/CustomEvent#polyfill
We are using
core-js
for several other polyfills, but that package has chosen not to supportCustomEvent
.Relevant slack thread.
Testing done
vets-website
down to a dependency upgrade forcomponent-library
from2.3.1
to2.4.0
. changesdispatchAnalyticsEvent
call by commenting it out and putting a simpleconsole.log('hi')
in the lifecycle method - the hca app loaded without theObject does not support this action
error and we saw the expected log message.vets-website
console.log
in the analytics event handler to verify that the CustomEvent is being fired.Screenshots
Acceptance criteria
Definition of done