Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some notes on best practice when updating models #104

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Add some notes on best practice when updating models #104

merged 2 commits into from
Apr 26, 2023

Conversation

brrygrdn
Copy link
Contributor

No description provided.

@brrygrdn brrygrdn requested a review from a team as a code owner April 26, 2023 14:03
jakecoffman
jakecoffman approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jakecoffman
jakecoffman reviewed Apr 26, 2023
View reviewed changes
internal/model/job.go Outdated Show resolved Hide resolved
@brrygrdn @jakecoffman
Fix syntax
87b7a32 
Co-authored-by: Jake Coffman <[email protected]>
@brrygrdn brrygrdn merged commit 1c2595e into main Apr 26, 2023
@brrygrdn brrygrdn deleted the brrygrdn/how-to-update-models branch April 26, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brrygrdn @jakecoffman