Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift to package manager mapping #142

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jul 7, 2023

So that the CLI is able to pull the swift image once it's there.

Part of https://github.com/github/dependabot-updates/issues/4371.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner July 7, 2023 16:08
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/add-swift-to-package-manager-mapping branch from 7f5cb85 to 686ebdd Compare July 12, 2023 18:45
@deivid-rodriguez
Copy link
Contributor Author

I think merging this can't harm even if the updater image is not yet available, correct?

@deivid-rodriguez
Copy link
Contributor Author

CI is broken, but it shouldn't be this PR's fault.

@jakecoffman
Copy link
Member

Yep, won't hurt anything to merge this now. Looks like #144 broke the tests, feel free to ignore.

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/add-swift-to-package-manager-mapping branch from 686ebdd to 1845f39 Compare July 17, 2023 14:19
@deivid-rodriguez deivid-rodriguez enabled auto-merge (squash) July 17, 2023 14:20
@deivid-rodriguez deivid-rodriguez merged commit d2773b6 into main Jul 17, 2023
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/add-swift-to-package-manager-mapping branch July 17, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants