fixing smoke test cache directory #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landongrindheim
approved these changes
Jul 14, 2023
jeffwidman
reviewed
Jul 17, 2023
| @@ -51,9 +51,7 @@ jobs: | |||
| # Download the Proxy cache. The job is ideally 100% cached so no real calls are made. | |||
| - name: Download cache | |||
| run: | | |||
| mkdir test-cache | |||
| cd test-cache | |||
| gh run download --repo dependabot/smoke-tests --name cache-${{ matrix.suite }} | |||
There was a problem hiding this comment.
This crept in via a copy paste from core/proxy... they don't set the --dir name arg. I'll open PR's to fix those.
This was referenced Jul 17, 2023
jeffwidman
added a commit
that referenced
this pull request
Jul 17, 2023
This particular command is getting long, so break it across multiple lines. This will also make the command invocation more consistent across the smoke workflows for core/proxy/cli repos. Related: * dependabot/dependabot-core#7576 * #148
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 17, 2023
This updates the command to match the smoke invocation used in the CLI and proxy. This should hopefully reduce mistakes creeping in like dependabot/cli#148 where I copy/pasted not realizing there was a slight difference between the two repos.
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Jul 17, 2023
This updates the command to match the smoke invocation used in the CLI and proxy. This should hopefully reduce mistakes creeping in like dependabot/cli#148 where I copy/pasted not realizing there was a slight difference between the two repos. Related: * dependabot/cli#150 * dependabot/cli#148
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#144 changed the cache download, so it didn't match what the dependabot command was using any more (
--cache=cache). This lines it back up.