Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix moby regression #156

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix moby regression #156

merged 2 commits into from
Jul 20, 2023

Conversation

jakecoffman
Copy link
Member

There's a bug in the the moby library with the latest Go 1.19 and 1.20 releases. Fixing it by pinning to the previous patch. I've updated to Go 1.20 while I was at it.

@jakecoffman jakecoffman requested a review from a team as a code owner July 20, 2023 14:44
@jakecoffman jakecoffman enabled auto-merge (squash) July 20, 2023 14:51
@jakecoffman jakecoffman merged commit 4fed58f into main Jul 20, 2023
@jakecoffman jakecoffman deleted the jakecoffman/pin-go-version branch July 20, 2023 14:54
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jeffwidman added a commit that referenced this pull request Aug 10, 2023
The upstream `moby` bug that triggered the temp pin has been fixed:
* #156
* docker/cli#4437

So no need to pin to specific patch versions anymore.

Update to `go` `1.21` while I was in there.
@jeffwidman jeffwidman mentioned this pull request Aug 10, 2023
jeffwidman added a commit that referenced this pull request Aug 15, 2023
The upstream `moby` bug that triggered the temp pin has been fixed:
* #156
* docker/cli#4437

So no need to pin to specific patch versions anymore.

Update to `go` `1.21` while I was in there.
jeffwidman added a commit that referenced this pull request Aug 15, 2023
The upstream `moby` bug that triggered the temp pin has been fixed:
* #156
* docker/cli#4437

So no need to pin to specific patch versions anymore.

Update to `go` `1.21` while I was in there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants