Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore any calls to increment_metric as irrelevant #93

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

brrygrdn
Copy link
Contributor

@brrygrdn brrygrdn commented Apr 6, 2023

As title, we don't need to handle or set expectations on these calls.

Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to log them?

@brrygrdn
Copy link
Contributor Author

brrygrdn commented Apr 6, 2023

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

@jakecoffman
Copy link
Member

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

@brrygrdn
Copy link
Contributor Author

brrygrdn commented Apr 6, 2023

  proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
  proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
  proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

@jakecoffman
Copy link
Member

LGTM looks like it just needs a run through the Go formatter.

@brrygrdn brrygrdn force-pushed the brrygrdn/api-server-ignores-metrics-calls branch from efbb285 to d35a483 Compare April 6, 2023 14:14
@brrygrdn brrygrdn force-pushed the brrygrdn/api-server-ignores-metrics-calls branch from d35a483 to a7a009a Compare April 6, 2023 14:19
@brrygrdn brrygrdn merged commit 74a0d67 into main Apr 6, 2023
@brrygrdn brrygrdn deleted the brrygrdn/api-server-ignores-metrics-calls branch April 6, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants