Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NPM V6 deprecation warning and unsupported error #11112

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Dec 12, 2024

What are you trying to accomplish?

Add changes to set NPM v6 as deprecated and unsupported. The deprecation warning and unsupported error are controlled by the following feature flags:

  • npm_v6_deprecation_warning
  • npm_v6_unsupported_error

Feature Flags PR: https://github.com/github/dependabot-api/pull/5763

This mirrors the approach used for Bundler v1 and composer 1, allowing us to guide users towards migrating to NPM v9 while providing a controlled rollout.

Anything you want to highlight for special attention from reviewers?

The deprecation and unsupported checks for NPM v6 are controlled by feature flags. Please focus on verifying that the logic tied to the feature flags works as expected.

How will you know you've accomplished your goal?

We will monitor logs and metrics to ensure:

  • NPM v6 users see the deprecation warning when the feature flag is enabled.
  • Actions using NPM v6 are blocked when the unsupported error flag is enabled.
  • Tests have been added to validate the behaviour of both feature flags.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe self-assigned this Dec 12, 2024
@amazimbe amazimbe force-pushed the amazimbe/deprecate-npm6 branch from 3a4bf75 to 8a2638c Compare December 13, 2024 09:29
@amazimbe amazimbe force-pushed the amazimbe/deprecate-npm6 branch from 8a2638c to 01c4dc9 Compare December 13, 2024 10:53
@amazimbe amazimbe marked this pull request as ready for review December 13, 2024 11:06
@amazimbe amazimbe requested a review from a team as a code owner December 13, 2024 11:06
Copy link
Contributor

@markhallen markhallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amazimbe amazimbe merged commit aae5818 into main Dec 13, 2024
68 checks passed
@amazimbe amazimbe deleted the amazimbe/deprecate-npm6 branch December 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants