Removing corepack usage from else clause

[thavaahariharangit]

What are you trying to accomplish?

Removing corepack usage from else clause.

        if Dependabot::Experiments.enabled?(:enable_corepack_for_npm_and_yarn)
          package_manager_run_command(NpmPackageManager::NAME, command, fingerprint: fingerprint)
        else
          Dependabot::SharedHelpers.run_shell_command(
            "npm #{command}",
            fingerprint: "npm #{fingerprint}"
          )
        end

if the corepack is enabled we can use corepack in the command otherwise it's not necessary to use corepack.

Anything you want to highlight for special attention from reviewers?

usage of core pack is forcing package.json to have packageManager version specified. But this is not a npm requirement.

For example packageManger specification in package.json

{
   ...
   "dependencies": {
      "your-dependency": "^1.0.0"
   },
   "packageManager": "[email protected]"
}

2025/01/14 14:57:26 WARN NPM : /usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22090
  throw new UsageError(`No version specified for ${raw2} in "packageManager" of ${source}`);
  ^

UsageError: No version specified for npm in "packageManager" of package.json
  at parseSpec (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22090:13)
  at loadSpec (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22164:11)
  at async Engine.findProjectSpec (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22354:22)
  at async Engine.executePackageManagerRequest (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:22410:24)
  at async Object.runMain (/usr/lib/node_modules/corepack/dist/lib/corepack.cjs:23102:5) {
  clipanion: { type: 'usage' }
}

How will you know you've accomplished your goal?

Ran the cli and ensured that there is no need for packageManager version specified in given packages.json

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.