Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding types to elm_json_updater.rb #11331

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

robaiken
Copy link
Contributor

@robaiken robaiken commented Jan 17, 2025

What are you trying to accomplish?

Add Sorbet type checking for elm_json_updater.rb

How will you know you've accomplished your goal?

All CI checks should pass and there shouldn't be any new errors in Sentry.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: elm Elm packages label Jan 17, 2025
@robaiken robaiken self-assigned this Jan 17, 2025
@robaiken robaiken marked this pull request as ready for review January 17, 2025 12:18
@robaiken robaiken requested a review from a team as a code owner January 17, 2025 12:18
markhallen
markhallen previously approved these changes Jan 17, 2025
Copy link
Contributor

@markhallen markhallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy Rock

@robaiken robaiken merged commit 8031523 into main Jan 21, 2025
55 checks passed
@robaiken robaiken deleted the robaiken/add-types-to-elm-json-updater branch January 21, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elm Elm packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants