Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for nuget v2 responses that don't specify a base #1472

Closed
wants to merge 3 commits into from

Conversation

ppejovic
Copy link
Contributor

@ppejovic ppejovic commented Oct 25, 2019

Some v2 nuget endpoints return no base attribute in the service node of the response, such as Inedo's ProGet like so:

<?xml version="1.0" encoding="utf-8"?>
<service xmlns="http://www.w3.org/2007/app">
    <workspace>
        <title xmlns="http://www.w3.org/2005/Atom">Default</title>
        <collection href="Packages">
            <title xmlns="http://www.w3.org/2005/Atom">Packages</title>
        </collection>
    </workspace>
</service>

Dependabot's current behavior results in such sources not being added to the list of dependency_urls that are probed for updates.

This fix uses the repo_details url in the case where a base url is not returned by the v2 api.

Further conversation with @feelepxyz here: c54d31c

@rebelagentm rebelagentm added the L: dotnet:nuget NuGet packages via nuget or dotnet label Oct 30, 2019
@stale
Copy link

stale bot commented Dec 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

@stale stale bot added the stale label Dec 27, 2019
@stale stale bot closed this Jan 4, 2020
@feelepxyz feelepxyz reopened this Jan 6, 2020
@stale stale bot removed the stale label Jan 6, 2020
@stale
Copy link

stale bot commented Mar 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

@stale stale bot added the stale label Mar 6, 2020
@stale stale bot closed this Mar 13, 2020
@ppejovic
Copy link
Contributor Author

ppejovic commented Apr 2, 2020

Could we get this reopened @feelepxyz? It's still a valid bug for us.

@feelepxyz feelepxyz reopened this Apr 2, 2020
@stale stale bot removed the stale label Apr 2, 2020
@feelepxyz feelepxyz added the T: bug 🐞 Something isn't working label Apr 2, 2020
@feelepxyz feelepxyz changed the base branch from master to main June 24, 2020 11:26
@jurre jurre mentioned this pull request Sep 10, 2020
@jurre
Copy link
Member

jurre commented Sep 10, 2020

Pulled this in via #2518

Thanks @ppejovic!

@jurre jurre closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants