Fix python path dependencies with file #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be helpful when testing file fetchers to be able to see what requests are being made by the specs. This commit makes it easier to add a debug logger to VCR; if you set the envvar DEPENDABOT_TEST_DEBUG_LOGGER to a valid path debug logs will be saved to that file.
Currently if a requirement file contains a path dependency where the path starts with `file:`, the file fetcher will try and find a file called `/file:./setup.py`, which fails because it should be looking for `setup.py`. This commit updates Dependabot::Python::FileFetcher to ignore the `file:` part if it is present.
lfdebrux
force-pushed
the
lfdebrux/fix-python-path-dependencies-with-file
branch
from
b4fe74d to
aaacc97
Compare
jurre
approved these changes
Sep 10, 2020
lfdebrux
deleted the
lfdebrux/fix-python-path-dependencies-with-file
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1977
This PR updates the regex in
Dependabot::Python::FileFetcher.parse_path_setup_pathsto ignore if there is afile:at the beginning of the requirement path.