Check the err returned by AddRequire #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the source of `AddRequire`, it looks like it never actually returns a non-`nil` error. However, they wrote the func signature to return an `err` to give themselves future flexibility. So we should respect that and check for any unexpected errors. This way future updates that suddenly start returning errors will be caught rather than insidiously slipping by and causing difficult-to-debug issues elsewhere.
thepwagner
approved these changes
Apr 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the source of
AddRequire, it looks like it never actually returns a non-nilerror: https://github.com/golang/mod/blob/858fdbee9c245c8109c359106e89c6b8d321f19c/modfile/rule.go#L828-L846However, they wrote the func signature to return an
errto give themselves future flexibility.So we should respect that and check for any unexpected errors. This way future updates that
suddenly start returning errors will be caught rather than insidiously slipping by and causing
difficult-to-debug issues elsewhere.