Refactor go module version finder specs #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that most of the tests that previously resided in update_checker_spec.rb have been moved into latest_version_finder_spec.rb, let's ensure we have a basic test that exercises the collaboration between UpdateChecker and LatestVersionFinder.
jasonrudolph
commented
May 10, 2021
| Dependabot::GoModules::Version.new("1.2.0-pre2") | ||
| ) | ||
| end | ||
|
|
||
| context "doesn't update indirect dependencies (not supported)" do |
There was a problem hiding this comment.
Since UpdateChecker includes comments specifically about indirect dependencies here, I've left this test here in update_checker_spec.rb instead of moving it to latest_version_finder_spec.rb.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As hinted at in #3661 (comment), this pull request takes the majority of the tests that resided in
go_modules/spec/dependabot/go_modules/update_checker_spec.rband moves them intogo_modules/spec/dependabot/go_modules/update_checker/latest_version_finder_spec.rb.The tests in
update_checker_spec.rbwere exercising functionality that lives inlatest_version_finder.rb, so it makes more sense for the tests to reside inlatest_version_finder_spec.rb. 😅To ensure that the higher-level functionality of
UpdateCheckerremains intact, d2d1eec adds a higher-level test to exercise the basic contract ofUpdateChecker#latest_resolvable_version.