Make toml an explicit requirement
#8626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
make-toml-import-explicit
branch
from
005c6e6 to
4abc9e1
Compare
This was referenced Dec 16, 2023
jeffwidman
force-pushed
the
make-toml-import-explicit
branch
from
4abc9e1 to
110d5b4
Compare
jeffwidman
force-pushed
the
make-toml-import-explicit
branch
from
110d5b4 to
fb42f12
Compare
|
Can I get a review on this? It's good to go. |
jeffwidman
force-pushed
the
make-toml-import-explicit
branch
2 times, most recently
from
2d0cb4e to
3e40ab1
Compare
|
@deivid-rodriguez @pavera can one of you take a look at this? To my eyes it's extremely straightforward, so I suspect it just got missed in the Christmas time busyness. |
I couldn't figure out why the tests were failing for: * dependabot#7741 until I realized that `pipfile` imports `toml`: https://github.com/pypa/pipfile/blob/4706d2cbd35e0b47a05a6421fa17f93827bc454f/setup.py#L44 which then gets used over in the unrelated file `parser.py`: https://github.com/dependabot/dependabot-core/blob/89ebc55dac8630574301a10917425f80a56e4763/python/helpers/lib/parser.py#L24 So let's make the import of `toml` explicit so that we aren't relying on the side effects of importing `pipfile`. The `toml` requirement from `pipfile` isn't pinned, so I simply pinned to the latest release. Python `3.11` added a native `tomllib` library, so once we drop support for `3.10` we can drop this 3p lib entirely.
jeffwidman
force-pushed
the
make-toml-import-explicit
branch
from
3e40ab1 to
f04a6b6
Compare
|
@abdulapopoola this is ready for review... |
abdulapopoola
approved these changes
Mar 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't figure out why the tests were failing for:
pipfiletoplettelib #8627)until I realized that
pipfileimportstoml:https://github.com/pypa/pipfile/blob/4706d2cbd35e0b47a05a6421fa17f93827bc454f/setup.py#L44
which then gets used over in the unrelated file
parser.py:dependabot-core/python/helpers/lib/parser.py
Line 24 in 89ebc55
So let's make the import of
tomlexplicit so that we aren't relying on the side effects of importingpipfile. Thetomlrequirement frompipfileisn't pinned, so I simply pinned to the latest release.Python
3.11added a nativetomlliblibrary, so once we drop support forPython 3.10we can drop this 3p lib entirely.