Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use credentials which have registry configured #9159

Merged
merged 4 commits into from
Mar 2, 2024
Merged

Only use credentials which have registry configured #9159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30f899a
Only use credentials which have `registry` configured
JamieMagee Feb 28, 2024
4b06356
Add a unit test
JamieMagee Feb 28, 2024
65636ef
Merge branch 'main' into jamiemagee/npm-credential-handling
bdragon Mar 1, 2024
1b91091
Merge branch 'main' into jamiemagee/npm-credential-handling
abdulapopoola Mar 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/registry_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def known_registries
begin
registries = []
registries += credentials
.select { |cred| cred["type"] == "npm_registry" }
.select { |cred| cred["type"] == "npm_registry" && cred["registry"] }
.tap { |arr| arr.each { |c| c["token"] ||= nil } }
registries += npmrc_registries
registries += yarnrc_registries
Expand Down
11 changes: 11 additions & 0 deletions npm_and_yarn/spec/dependabot/npm_and_yarn/update_checker/registry_finder_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,6 +403,17 @@

it { is_expected.to eq("registry.npmjs.org") }
end

context "with credentials that don't have a registry" do
before do
credentials << Dependabot::Credential.new({
"type" => "npm_registry",
"registry" => nil
})
end

it { is_expected.to eq("registry.npmjs.org") }
end
end

describe "#auth_headers" do
Expand Down
Loading