[BUG] Fatal error for tasks without description (PHP7.4, symfony/console ^5.0)

[sirian]

<?php
namespace Deployer;

task('test', function(){});

{
    "require": {
        "symfony/console": "^5.0",
        "deployer/deployer": "^6.7"
    }
}

[sirian]

@antonmedv

[antonmedv]

What PHP version? Works for me.

[sirian]

@antonmedv php7.4 i mentioned it in subject :)

[sirian]

[antonmedv]

I see. This is odd, as I just testes it in 7.4 and for me everything is working.

[sirian]

probably you tried at symfony/console 4. Bug happens with symfony/console 5.

Try this

rm -rf /tmp/test && mkdir /tmp/test && cd /tmp/test
echo "<?php namespace Deployer;task('test', function(){});" > deploy.php
composer require symfony/console:^5.0 deployer/deployer:^6.7
vendor/bin/dep

[antonmedv]

Okay, will try this

[sirian]

@antonmedv And there are plenty more errors due to type hints in symfony/console 5 and some breacking changes. For example

[antonmedv]

Yeah. Looks like PR for symphony 5 was incomplete.

[sirian]

`composer require --dev phpstan/phpstan` (or any other static code analyzer) will help you analyze code and fix bugs вс, 15 дек. 2019 г., 13:30 Anton Medvedev <[email protected]>:

…

Yeah. Looks like PR for symphony 5 was incomplete. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1969?email_source=notifications&email_token=AAG3E2ZSETDODR6SWHE4O73QYYBM3A5CNFSM4J22TMS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4V6MQ#issuecomment-565796658>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG3E22MEMLE2XAHXZWFVX3QYYBM3ANCNFSM4J22TMSQ> .

[antonmedv]

Got only one error:

vendor/bin/phpstan analyse src
 79/79 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------
  Line   Initializer/Exception/TemplateNotFoundException.php
 ------ -------------------------------------------------------
  29     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
 ------ -------------------------------------------------------


 [ERROR] Found 1 error

[antonmedv]

Done in 86c7b38

[sirian]

Got only one error:

vendor/bin/phpstan analyse src
 79/79 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------
  Line   Initializer/Exception/TemplateNotFoundException.php
 ------ -------------------------------------------------------
  29     Unsafe usage of new static().
         💡 Consider making the class or the constructor final.
 ------ -------------------------------------------------------


 [ERROR] Found 1 error

@antonmedv Consider to check with strict phpstan-strict-rules and witth vimeo/psalm. Currently on master psalm displays 95 errors, phpstan - 89

composer require --dev phpstan/phpstan phpstan/phpstan-strict-rules phpstan/extension-installer vimeo/psalm
vendor/bin/phpstan analyse src
vendor/bin/psalm --show-info=false src

For example psalm errors:

[sirian]

currently (6.7.1) ssh cleanup doesn't work :(

➤ Executing task cleanup

 [TypeError] Argument 1 passed to Symfony\Component\Process\Process::__construct() 
must be of the type array, string given
called in /tmp/test/vendor/deployer/deployer/src/Ssh/Client.php on line 149

and psalm detects 7 errors in Ssh\Client.php

[antonmedv]

Working on it too)

[staabm]

just in case others stumbling over this:

when using php 7.0 the latest version one gets is deployer v6.7.1, but because of the above mentioned errors, which get fixed in v6.7.2 renders deployer useless (since v6.7.2 requires php 7.2).

bottom line: don't trust composer which installs deployer 6.7.1 for your php 7.0. you need to either update your php or overrule composer automatics and use 6.7.0