Error returns code 0

[garak]

• Deployer version: 7.0.0-beta.13
• Deployment OS: Ubuntu 20.04

I'm getting following error

TypeError in Stringify.php on line 67:
Argument 1 passed to Deployer\Support\Stringify::escape() must be of the type string, bool given, called in phar:///home/circleci/app/bin/dep/src/Support/Stringify.php on line 35

See attached image:

apart from weird error, I would expect that such case would return a code different from zero (otherwise I'm not able to notice that something went wrong)

[antonmedv]

Can you show you deploy.php? Or provide some example?

[garak]

I'm not sure my config can be relevant (apart from the error on escape, that's secondary).
The main problem here is that deployer is not taking into account exceptions/errors to give a proper return code.

[cafferata]

It's in the Deployer options --no-ansi, --ansi, --no-interaction

<?php

namespace Deployer;

require_once __DIR__.'/vendor/deployer/deployer/recipe/symfony.php';

set('repository', '[email protected]:deployphp/deployer.git');

$host = host('deployer.org');
$host->setRemoteUser('test');
$host->setDeployPath('/var/www/');

./vendor/bin/dep deploy --no-ansi

Deployer\Support\Stringify::escape(): Argument #1 ($token) must be of type string, bool given, called in /Users/cafferata/jcid/deployphp/deployer/vendor/deployer/deployer/src/Support/Stringify.php on line 35

./vendor/bin/dep deploy --ansi

Deployer\Support\Stringify::escape(): Argument #1 ($token) must be of type string, bool given, called in /Users/cafferata/jcid/deployphp/deployer/vendor/deployer/deployer/src/Support/Stringify.php on line 35

./vendor/bin/dep deploy --no-interaction

Deployer\Support\Stringify::escape(): Argument #1 ($token) must be of type string, bool given, called in /Users/cafferata/jcid/deployphp/deployer/vendor/deployer/deployer/src/Support/Stringify.php on line 35

[cafferata]

I can't (yet) oversee the impact of this commit 18bdfc8#diff-b872a77de62f6d05e055c5c2c19e0175ad4b9f4075531eee37dcba67a6d3cea8R63

Dump of $input->getOptions():

array:18 [
  "tag" => null
  "revision" => null
  "branch" => null
  "option" => []
  "limit" => null
  "no-hooks" => false
  "plan" => false
  "start-from" => null
  "log" => null
  "profile" => null
  "help" => false
  "quiet" => false
  "verbose" => false
  "version" => false
  "ansi" => true
  "no-ansi" => false
  "no-interaction" => true
  "file" => null
]

            foreach ($option as $value) {
+                if(is_bool($value)){
+                    $options[] = "--$name";
+                    continue;
+                }
+
                $options[] = "--$name " . self::escape((string)$value);
            }

Output of Stringify::options() before/after:

-"--ansi 1 --decorated"
+"--ansi --decorated"