Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashes on including autoloader in recipe file #1833

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Fix crashes on including autoloader in recipe file #1833

merged 3 commits into from
Jul 17, 2019

Conversation

xtac
Copy link
Contributor

@xtac xtac commented Apr 19, 2019

Q A
Bug fix? Yes
New feature? No
BC breaks? No
Deprecations? No
Fixed tickets #1602

@xtac xtac force-pushed the feature/fix_autoload_bug branch 2 times, most recently from 0412cb8 to 9a93a24 Compare April 19, 2019 04:23
@xtac xtac force-pushed the feature/fix_autoload_bug branch from 9a93a24 to 15f4c5a Compare April 19, 2019 04:26
@antonmedv
Copy link
Member

Awesome! Can you explain a little bit how you solved it?

@xtac
Copy link
Contributor Author

xtac commented Apr 19, 2019

first. sorry to my poorly english.

The deployer works with many classes in deployer.phar file.
but, if recipe file includs autoload.php (generated by composer) then autoload stack changed at running time.
(composer always put it at the front of the autoloader stack)

so, autoloader might serve uncompatible class with deployer
(e.g. \Symfony\Component\Console\Helper\QuestionHelper)

@antonmedv antonmedv merged commit 756f121 into deployphp:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonmedv antonmedv antonmedv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtac @antonmedv