Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks to cache a manifest of event listeners #1893

Merged
merged 2 commits into from
Aug 6, 2019
Merged

Add tasks to cache a manifest of event listeners #1893

merged 2 commits into from
Aug 6, 2019

Conversation

wgriffioen
Copy link
Contributor

Q A
Bug fix? No
New feature? Yes
BC breaks? No
Deprecations? No
Fixed tickets N/A

Laravel supports automatic discovery of events and listeners since
version 5.8.9. (https://laravel.com/docs/5.8/events#event-discovery)
As the documentation states, you want to cache the manifest of event
listeners in a production environment to prevent scanning the
directories on every request.

The new tasks are not added to the deploy task because automatic event
discovery is opt-in functionality in Laravel.

Laravel supports automatic discovery of events and listeners since
version 5.8.9. (https://laravel.com/docs/5.8/events#event-discovery)
As the documentation states, you want to cache the manifest of event
listeners in a production environment to prevent scanning the
directories on every request.

The new tasks are not added to the deploy task because automatic event
discovery is opt-in functionality in Laravel.
@wgriffioen wgriffioen marked this pull request as ready for review August 5, 2019 12:15
@antonmedv antonmedv merged commit a6ff2eb into deployphp:master Aug 6, 2019
@wgriffioen wgriffioen deleted the add-event-cache-task branch August 7, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants