More Symfony 5 compatibility fixes #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
approved these changes
Dec 16, 2019
|
Could this be merged and released? :) |
sirian
reviewed
Dec 16, 2019
| @@ -43,7 +43,11 @@ public function call($hostname, $source, $destination, array $config = []) | |||
|
|
|||
| $this->pop->command($hostname, $rsync); | |||
|
|
|||
| $process = new Process($rsync); | |||
| if (method_exists('Symfony\Component\Process\Process', 'fromShellCommandline')) { | |||
There was a problem hiding this comment.
Maybe replace with if (method_exists(Process::class, 'fromShellCommandline'))?
There was a problem hiding this comment.
I agree that would be slightly cleaner. For now I used the exact same fix that was already present in e.g. Deployer\Utility\ProcessRunner for consistency. The best long-term solution would probably be to have a utility function somewhere in the deployer codebase to contain this compatibility layer.
sirian
reviewed
Dec 16, 2019
|
|
||
| private function createProcess($command) | ||
| { | ||
| if (method_exists('Symfony\Component\Process\Process', 'fromShellCommandline')) { |
There was a problem hiding this comment.
Maybe replace with if (method_exists(Process::class, 'fromShellCommandline'))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hate to bring the bad news here after your previous efforts to support Symfony 5, but there are still incompatibilities with symfony/process` 5.x in the Rsync- and SSH-client. This PR should fix them.