fix(playwright): skip unloaded iframes #1060

straker · 2024-05-13T15:12:35Z

Pulled out of #1048. Starting in Playwright 1.41.0 (using Chrome version 121.0.6167.57) Playwright is no longer loading the lazy loaded iframe that is out of view. Updated the version of Playwright and updated the tests to now account for this.

QA notes: Test a lazy loaded iframe with Playwright > 1.41.0 and ensure Playwright will complete an analyze of the page

straker · 2024-05-13T15:12:59Z

packages/playwright/src/index.ts

@@ -185,7 +185,14 @@ export default class AxeBuilder {

  private async inject(frames: Frame[]): Promise<void> {
    for (const iframe of frames) {
-      await iframe.evaluate(await this.script());
+      const race = new Promise((_, reject) => {


The newer versions of Playwright with the update to Chrome, combined with our changes to the lazy loaded frame test now make it so Playwright is not loading the lazy loaded iframe when it is outside the viewport.

Playwright does not have a pageload timeout like all the other drivers, and neither does the evaluate function have a timeout option. So this was the only other choice to have the lazy loaded iframe not hang indefinitely.

Zidious

One comment inline -

packages/playwright/src/index.ts

Resolved

## [4.9.1](v4.9.0...v4.9.1) (2024-05-15) ### Bug Fixes * **playwright:** skip unloaded iframes ([#1060](#1060)) ([d30dae4](d30dae4)) * Update axe-core to v4.9.1 ([#1055](#1055)) ([8644fbd](8644fbd)) No qa needed

padmavemulapati · 2024-05-17T13:10:51Z

Verified with the latest canary-build (4.7.4-62fd241.0)
Lazy-loaded iframes are scanning properly now, not hanging,

1. Here is iframes snippets:

lazyloadedIframe.html

<!DOCTYPE html>
<!DOCTYPE html>
<html lang="en" id="lazy-loading-iframe-root">
  <head>
    <title>Lazy Loading Iframe Root</title>
  </head>
  <body>
    <main>
      <h1>iframe context test</h1>
      <div style="margin-top: 3000vh">
        <iframe src="iframes/lazy.html" id="ifr-lazy" loading="lazy"></iframe>
      </div>
    </main>
  </body>
</html>

2. for this iframes - directory has a lazy.html file too

./iframes.lazy.html

<!DOCTYPE html>
<html lang="en">
  <head>
    <title>Lazy</title>
  </head>
  <body>
    <h1>Lazy</h1>
    <div style="margin-top: 3000vh">
      <iframe id="lazy-iframe" src="https://www.youtube.com/embed/REDRiwmNunA" title="MONTHLY SPOTLIGHT" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" loading="lazy"></iframe>
      <iframe src="baz.html" id="lazy-baz"></iframe>
    </div>
  </body>
</html>

3. for Playwright 1.44.0 Version and v1.42.1 :

TestScript:

const { AxeBuilder } = require('@axe-core/playwright')
const playwright = require('playwright')
const fs = require('fs')
const axe = require('axe-core')

;(async () => {
  const browser = await playwright.chromium.launch({ headless: true })
  const context = await browser.newContext()
  const page = await context.newPage()
  await page.goto('http://localhost:8081/iframesfixture.html')

  try {
   const results = await new AxeBuilder({page}).analyze();
    fs.writeFileSync('./lazyloadedIframes144.json', JSON.stringify(results, null, 4))
  } catch (e) {
    console.error(e)
  }

  await browser.close()
})()

Result for 1.44.0:

Result for 1.42.1:

4. For Puppeteer v22.9.0 and v22.6.3.

test-script:

const { AxePuppeteer } = require('@axe-core/puppeteer');
const puppeteer = require('puppeteer');
const fs = require('fs');

(async () => {
  const browser = await puppeteer.launch({ headless: false });
  const page = await browser.newPage();
  await page.setBypassCSP(true);
  await page.goto('http://localhost:8081/iframesfixture.html');
  const results = await new AxePuppeteer(page).analyze();
    fs.writeFile("./lazyframes_frametested.json", JSON.stringify(results, null,4),(err)=>
    {if(err){
        console.error(err);
        return;
        };
        console.log("File has been created");
    })

  await page.close();
  await browser.close();
})();

Results:
For 22.9.0

For 22.6.3

5.for webdriverjs - selenium-webdriver v4.21.0 & v4.19.0:

Test-script:

const { AxeBuilder } = require('@axe-core/webdriverjs');
const { Builder } = require('selenium-webdriver');
const chrome = require('selenium-webdriver/chrome');
const fs = require('fs');

(async () => {
  const driver = new Builder()
    .forBrowser('chrome')
    .setChromeOptions(new chrome.Options().headless())
    .build();
  await driver.get('http://localhost:8081/iframesfixture.html');
  try {
    const results = await new AxeBuilder(driver).analyze();
    fs.writeFile("./lazyiframestest.json", JSON.stringify(results, null,4),(err)=>
    {if(err){
        console.error(err);
        return;
        };
        console.log("File has been created");
    })
  } catch (e) {
    // do something with the error
  }

  await driver.quit();
})();

Result:
For 4.21.0

For 4.19.0

5. for CLI (selenium-webdriver v4.21.0 & 4.19.0)-

command is `axe http://localhost:8081/iframesfixture.html --save ./iframesresult1`

for selenium webdriver v4.21.0

for selenenium webdriver v4.19.0

6. for webdriverio:

TestScript:

const AxeBuilder = require('@axe-core/webdriverio').default;
const { remote } = require('webdriverio');
const fs = require('fs');

(async () => {
  const client = await remote({
    logLevel: 'error',
    capabilities: {
      browserName: 'chrome'
    }
  });

  await client.url('http://localhost:8081/iframesfixture.html');

  const builder = new AxeBuilder({ client });
  const results = await builder.analyze();
    fs.writeFile("./lazyiframestest.json", JSON.stringify(results, null,4),(err)=>
    {if(err){
        console.error(err);
        return;
        };
        console.log(results);
    })
   client.deleteSession();
})();

Result:

for 8.36.1

for 8.35.1

Environment:

Label	Value
Product	axe-core-npm
Version	4.9.2-a2f07c5.0
Playwright	1.44.0 & 1.42.1
Puppeteer	22.9.0 & 22.6.3
WebdriverIO	_8.36.1 & 8.35.1 _
Selenium-webdriver(WebdriverJS & CLI)	_ v4.21.0 & 4.19.0 _
OS-Details	_MAC- M1-14.4 & Windows11 _
BrowserDetails	Chrome Version 124.0.1 (Official Build) (64-bit) & Firefox 125.0.3

fix(playwright): skip unloaded iframes

b57bfd0

straker requested a review from a team as a code owner May 13, 2024 15:12

straker commented May 13, 2024

View reviewed changes

straker mentioned this pull request May 13, 2024

chore: bump the npm-low-risk group with 28 updates #1048

Closed

Zidious previously requested changes May 13, 2024

View reviewed changes

packages/playwright/src/index.ts Show resolved Hide resolved

throw only in run partial

41032a0

Zidious approved these changes May 13, 2024

View reviewed changes

straker merged commit d30dae4 into develop May 13, 2024
30 checks passed

straker deleted the playwright-lazy branch May 13, 2024 17:46

github-actions bot mentioned this pull request May 15, 2024

chore: RC v4.9.1 #1065

Merged

dequejenn mentioned this pull request May 20, 2024

Release v4.9.1 #1068

Merged

data-sync-user mentioned this pull request Jun 3, 2024

Bump @axe-core/react from 4.9.0 to 4.9.1 MozillaFoundation/foundation.mozilla.org#12380

Merged

gurudeep9 mentioned this pull request Jun 23, 2024

[Snyk] Upgrade @axe-core/playwright from 4.9.0 to 4.9.1 gurudeep9/mattermost-test#3

Open

aravindb26 mentioned this pull request Jul 16, 2024

[Snyk] Upgrade @axe-core/webdriverjs from 4.8.2 to 4.9.1 aravindb26/spark#1

Open

n1ghtmar3-6251 mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @axe-core/webdriverjs from 4.7.3 to 4.9.1 n1ghtmar3-6251/spark#1

Open

aravindb26 mentioned this pull request Jul 22, 2024

[Snyk] Upgrade @axe-core/webdriverjs from 4.8.2 to 4.9.1 aravindb26/spark#4

Open

n1ghtmar3-6251 mentioned this pull request Jul 23, 2024

[Snyk] Upgrade @axe-core/webdriverjs from 4.7.3 to 4.9.1 n1ghtmar3-6251/spark#5

Open

This was referenced Sep 8, 2024

[Snyk] Upgrade: , hackme252/spark#2

Open

[Snyk] Upgrade: , hackme252/spark#3

Open

[Snyk] Upgrade: , hackme252/spark#4

Open

[Snyk] Upgrade: , hackme252/spark#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(playwright): skip unloaded iframes #1060

fix(playwright): skip unloaded iframes #1060

straker commented May 13, 2024 •

edited

Loading

straker May 13, 2024 •

edited

Loading

Zidious left a comment

padmavemulapati commented May 17, 2024 •

edited

Loading

command is `axe http://localhost:8081/iframesfixture.html --save ./iframesresult1`

fix(playwright): skip unloaded iframes #1060

fix(playwright): skip unloaded iframes #1060

Conversation

straker commented May 13, 2024 • edited Loading

straker May 13, 2024 • edited Loading

Choose a reason for hiding this comment

Zidious left a comment

Choose a reason for hiding this comment

padmavemulapati commented May 17, 2024 • edited Loading

command is axe http://localhost:8081/iframesfixture.html --save ./iframesresult1

Environment:

straker commented May 13, 2024 •

edited

Loading

straker May 13, 2024 •

edited

Loading

padmavemulapati commented May 17, 2024 •

edited

Loading

command is `axe http://localhost:8081/iframesfixture.html --save ./iframesresult1`