ci: enable manual running of release #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously approved these changes
Aug 1, 2023
AdnoC
force-pushed
the
ci-patch-thrusday
branch
from
d4b429f to
54496c0
Compare
AdnoC
force-pushed
the
ci-patch-thrusday
branch
from
e88c534 to
0e3ac31
Compare
AdnoC
force-pushed
the
ci-patch-thrusday
branch
from
0e3ac31 to
455850a
Compare
AdnoC
changed the title
This reverts commit 455850a.
Zidious
previously requested changes
Sep 1, 2023
.github/scripts/prepare_release.sh
Outdated
Comment on lines
9
to
11
| version=$(node -pe 'require("./lerna.json").version') | ||
| jq '.version = $newVer' --arg newVer "$version" package.json > tmp | ||
| mv tmp package.json |
There was a problem hiding this comment.
Any particular reason why we're bumping the root package json? Lerna only bumps packages we're publishing or care about
There was a problem hiding this comment.
I'm trying not to change the action while work on it is being done, so this is needed. The action assumes that the top level package.json is the source of truth for what version the package is.
There was a problem hiding this comment.
PR for not doing this is in api-team-public
package.json
Outdated
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "axe-core-npm", | |||
| "version": "4.7.3", | |||
This reverts commit e887784.
Zidious
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR: #809
Test Issue: #808
Conditional checks were tested in a personal repo: https://github.com/AdnoC/action-test/actions/workflows/push-and-dispatch.yml
https://github.com/dequelabs/axe-api-team/issues/355
https://github.com/dequelabs/axe-api-team/issues/342