update based on reviews

dequelabs · Apr 23, 2019 · 8ab5d1a · 8ab5d1a
1 parent c3e0408
commit 8ab5d1a
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/test/core/utils/get-scroll.js b/test/core/utils/get-scroll.js
@@ -44,6 +44,8 @@ describe('axe.utils.getScroll', function() {
 		var actual = axe.utils.getScroll(target.actualNode);
 		assert.isDefined(actual);
 		assert.hasAllKeys(actual, ['elm', 'top', 'left']);
+		assert.equal(actual.top, 0);
+		assert.equal(actual.left, 0);
 	});
 
 	it('returns scroll offset when element overflow is auto', function() {
@@ -57,6 +59,8 @@ describe('axe.utils.getScroll', function() {
 		var actual = axe.utils.getScroll(target.actualNode);
 		assert.isDefined(actual);
 		assert.hasAllKeys(actual, ['elm', 'top', 'left']);
+		assert.equal(actual.top, 0);
+		assert.equal(actual.left, 0);
 	});
 
 	it('returns undefined when element overflow is visible', function() {
@@ -74,6 +78,8 @@ describe('axe.utils.getScroll', function() {
 		var actual = axe.utils.getScroll(target.actualNode);
 		assert.isDefined(actual);
 		assert.hasAllKeys(actual, ['elm', 'top', 'left']);
+		assert.equal(actual.top, 0);
+		assert.equal(actual.left, 0);
 	});
 
 	describe('shadowDOM - axe.utils.getScroll', function() {
@@ -110,6 +116,8 @@ describe('axe.utils.getScroll', function() {
 			var actual = axe.utils.getScroll(target.actualNode);
 			assert.isDefined(actual);
 			assert.hasAllKeys(actual, ['elm', 'top', 'left']);
+			assert.equal(actual.top, 0);
+			assert.equal(actual.left, 0);
 		});
 	});
 });
diff --git a/test/integration/rules/scrollable-region-focusable/scrollable-region-focusable.json b/test/integration/rules/scrollable-region-focusable/scrollable-region-focusable.json
@@ -2,5 +2,5 @@
 	"description": "scrollable-region-focusable tests",
 	"rule": "scrollable-region-focusable",
 	"violations": [["#fail1"], ["#fail2"], ["#fail3"]],
-	"passes": [["#fixture"], ["#pass1"], ["#pass2"], ["#pass3"]]
+	"passes": [["#pass1"], ["#pass2"], ["#pass3"]]
 }
diff --git a/test/rule-matches/scrollable-region-focusable-matches.js b/test/rule-matches/scrollable-region-focusable-matches.js
@@ -20,6 +20,18 @@ describe('scrollable-region-focusable-matches', function() {
 		assert.isFalse(actual);
 	});
 
+	it('returns false when element has no visible children', function() {
+		var target = queryFixture(
+			'<div id="target" style="height: 200px; width: 200px;">' +
+				'<div style="display:none; height: 2000px; width: 100px;">' +
+				'<p> Content </p>' +
+				'</div>' +
+				'</div>'
+		);
+		var actual = rule.matches(target.actualNode, target);
+		assert.isFalse(actual);
+	});
+
 	it('returns false when element does not overflow', function() {
 		var target = queryFixture(
 			'<div id="target" style="height: 200px; width: 200px; overflow: auto;">' +