feat(rule): aria-roledescription

[straker]

Aria-roledescription required too many nuances that couldn't adequately be captured in just an unsupported object:

• required matching a list of supported roles
• matcher objects don't allow matching of elements with implicit roles
• required failing on any element without a role

As such, it was easier to turn it into its own rule that could capture these nuances. This is the same problem we'll encounter when trying to support role="text" as we'd want to make sure that it isn't used on an element with interactive children (something else that can't be captured in an unsupported object).

Closes issue: #1517

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

• Follows the commit message policy, appropriate for next version
• Code is reviewed for security

[dylanb]

What about the documentation?

Added a couple of comments that you should address

Resolved

[jeeyyy]

Some nitpick inline comments.

[jeeyyy]

nitpick, destructuring will be easier to read & will remove line 4.

const { supportedRoles = [] } = options

[jeeyyy]

nitpick, exit early again easier to read.

if(!role) {
  return false
}

if(!['presentation', 'none'].includes(role)) {
 return undefined
}

[WilcoFiers]

Disagree. There is a single "exit early" condition here. Splitting that over two if-statements is confusing. Readability isn't just about having shorter statements.

[WilcoFiers]

Disagree. There is a single "exit early" condition here. Splitting that over two if-statements is confusing. Readability isn't just about having shorter statements.