tests: ensure after and reporter methods can run in isolated context #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Aug 26, 2021
|
|
||
| function setEmptyReporter() { | ||
| win.axeConfigure({ | ||
| reporter: function(results, options, callback) { |
There was a problem hiding this comment.
This looks like the raw reporter. Why not use that?
There was a problem hiding this comment.
I didn't want to use a reporter in case the reporter throws. A simple custom reporter ensures it wont throw by accessing things it shouldn't
Co-authored-by: Wilco Fiers <[email protected]>
WilcoFiers
approved these changes
Aug 26, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
…3136) * tests: ensure after and reporter methods can run in isolated context * Update test/integration/full/isolated-env/isolated-env.js Co-authored-by: Wilco Fiers <[email protected]> * cleanup Co-authored-by: Wilco Fiers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a difficult one to set up. Hopefully this does what we want and ensures our after and reporter methods can run when
windowanddocumentare not there.