-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix typos and grammar issues #4647
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… jmr-docs "docs: typo and grammar corrections"
This reverts commit 5cc523b.
dbjorge
changed the title
docs: requested changes made
docs: fix typos and grammar issues
Dec 10, 2024
I fixed up the remaining comments from my review in #4642 to get this unblocked. The changes look good to me, but @WilcoFiers will need to cover the final review/approval/security approval since I added some commits. |
dbjorge
approved these changes
Dec 10, 2024
Great, once this one gets approved I will perform the nmtoken one |
WilcoFiers
approved these changes
Dec 10, 2024
Thank you for the good work @Jeremy-Rivera! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<< Describe the changes >>
Requested changes made