Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos and grammar issues #4647

Merged
merged 10 commits into from
Dec 10, 2024
Merged

docs: fix typos and grammar issues #4647

merged 10 commits into from
Dec 10, 2024

Conversation

Jeremy-Rivera
Copy link
Contributor

<< Describe the changes >>

Requested changes made

@Jeremy-Rivera Jeremy-Rivera requested a review from a team as a code owner November 26, 2024 22:36
@Jeremy-Rivera Jeremy-Rivera changed the title Jmr docs docs: requested changes made Nov 26, 2024
@dbjorge dbjorge changed the title docs: requested changes made docs: fix typos and grammar issues Dec 10, 2024
@dbjorge
Copy link
Contributor

dbjorge commented Dec 10, 2024

I fixed up the remaining comments from my review in #4642 to get this unblocked. The changes look good to me, but @WilcoFiers will need to cover the final review/approval/security approval since I added some commits.

@dbjorge dbjorge requested a review from WilcoFiers December 10, 2024 00:27
@Jeremy-Rivera
Copy link
Contributor Author

Great, once this one gets approved I will perform the nmtoken one

@WilcoFiers
Copy link
Contributor

Thank you for the good work @Jeremy-Rivera!

@WilcoFiers WilcoFiers merged commit 71cbd90 into develop Dec 10, 2024
23 checks passed
@WilcoFiers WilcoFiers deleted the jmr-docs branch December 10, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants