k9s container shell broken since 0.24.3 for Windows 10 any shell (windows terminal, cmd.exe, cmder.exe, bash.exe)

[Slach]

Describe the bug
When I open a shell in any container, k9s doesn't show cursor and broke whole k9s layout after exit from shell

To Reproduce
Steps to reproduce the behavior:

1. Go to ':pods'
2. Click on 'any pod'
3. Press to 's'
4. See error
5. Enter exit command
6. See broken layout and cursor didn't show after exit from k9s

Expected behavior
correct works with shell

Screenshots

v0.24.4 video https://recordit.co/ADY6TrH0Bq

v0.24.2 video on same machine and settings https://recordit.co/laPW7NJAp0

Versions (please complete the following information):

• OS: Windows 10 1909
• K9s: 0.24.3+
• kubectl: 1.20.5

Additional context
It easy to reproduce with the same behavior (lost cursor, lost layout) inside cmd.exe and Windows Terminal 1.6 and 1.7 preview, and inside cygwin bash or cmder or clink

[StraggleCraft]

also broken on windows 8 using conemu

[derailed]

@Slach Great details on this issue. Thank you Eugene! Not sure I got this. Can't repro since I don't have access to windows ;(
Please give v024.5 a rinse and let us know if we're happier... Tx!

[Slach]

@derailed
0.24.5 still broken

maybe you can try to analyze something breaking changes in dependencies between 0.24.2 and 0.24.3?

[Slach]

0.24.6 still broken

but
@derailed JFYI change in go.mod

github.com/derailed/tview v0.4.11
github.com/gdamore/tcell/v2 v2.1.0

and run

go mod download -x
go mod tidy
make build

resolve my issue

could you reopen this issue?

[derailed]

@Slach Thanks for reporting back! Getting closer... Curious? Could you try downgrading tcell to v2.1.0 and keeping tview at v0.5.2. Does it work then?

[Slach]

tview 0.5.2 require tcell 2.2.0+
look to https://github.com/derailed/tview/blob/master/go.mod#L6

so when I modify k9s/go.mod for tview, it actually changed automatically after go mod download/go mod tidy for tcell
I don't know how to resolve it

[manuelneubergerwn]

We are having the same issue (also working on windows).

[julien-hascoet]

Hello there,

I confirm that with the @Slach solution it works 👍

I made the changes in the go.mod file and then run the following :

go mod download -x
go mod tidy
go build

(yes go build instead of make build, make was throwing errors -> windows hey 😒)

I have a binary k9s.exe that does not have versioning but it works !

Hope it helps.

[derailed]

@Slach @StraggleCraft @julien-hascoet @manuelneubergerwn You guys rock!! Thank you all for you feedback and inputs!
I hope I have a fix for this (crossing fingers and toes..) Please see v0.24.7 'with feelings' drop. If not back the drawing board ;(

[Slach]

@derailed screen restored properly, but cursor still hidden, so issue resolved partially

[Slach]

@derailed screen doesn't broken anymore
but cursor still hide after just run k9s.exe and exit

[manuelneubergerwn]

@derailed Yes, it seems the main problem is fixed. Thanks a lot.

[Slach]

@manuelneubergerwn @StraggleCraft @julien-hascoet
could you confirm? in your environment cursor hide after running any shell or just after exiting from k9s?

[derailed]

@manuelneubergerwn Thank you for your appreciation! Refreshing to see positive PR comments once in a while!!

@Slach I was kind of happy to have fixed the main blocker ;( So I'll say more than partially fixed would be in order here??
Let's open a new issue for the cursor disappearing act which I think is not as critical especially in light of having experienced the very cursor disappearing trick on windoze using straight up kubectl!

Now dragging the 20 pound windows laptop aka the boat anchor back to my neighbor. Serenity Now!

[guilhemrambal]

It Works ! @derailed

[manuelneubergerwn]

@Slach It seems that my curser is still missing when I run any shell in k9s. After leaving k9s every works fine.
But for me, the missing cursor is not a problem.

[Slach]

@manuelneubergerwn look to #1070
Could you share a short screencast for cursor behavior in your environment?
Which shell do you use to run k9s, it's a standard cmd.exe? Did you try to use Windows Terminal or CMRer?

I agree lost cursor is not a show stopper bug, but it annoying bug which came from dependencies, and I think analyze changes inside dependencies can show us why cursor hidden

[NeXT405]

@Slach same issue for me with the cursor on Windows.

v0.24.3

v0.24.7

Windows Version:
Microsoft Windows 10 Pro
Version: 10.0.19041 Build 19041

Tested with the default CMD and the Windows Terminal (1.6.10571.0)

Feel free to ask for more informations or for testing.

[Slach]

@NeXT405 please follow #1070