Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by namespace doesn't seem to be working #314

Closed
dserodio opened this issue May 24, 2024 · 7 comments
Closed

Filter by namespace doesn't seem to be working #314

dserodio opened this issue May 24, 2024 · 7 comments

Comments

@dserodio
Copy link

Describe the bug
I run popeye -n communication-engine -o jurassic, and Popeye shows the same results as if I run popeye -A -o jurassic, as confirmed by diff. Tthere's only a couple of lines that are in different positions and a different timestamp.

Versions (please complete the following information):

  • macOS 14.5
  • Popeye 0.21.3
  • K8s v1.27.12
@haiwu
Copy link

haiwu commented Jun 2, 2024

Just hit the same issue

@JanMezey
Copy link

we have the same issue

@ssurovich
Copy link

I have the same issue - is this a known bug/issue right now?

@irLinja
Copy link

irLinja commented Aug 5, 2024

This issue has been open for a while, and it's breaking our pipelines.
For now, we have to pin to v.0.11.3, but it will be great to upgrade and use new features.
@derailed

@dcarrolloreilly
Copy link

Looks like in pkg/popeye.go on about line 267 there is an issue causing this. That line is: ctx = context.WithValue(ctx, internal.KeyNamespace, client.ClusterScope) and if you override client.ClusterScope with "namespace" where namespace is the one you want to filter, it works. There is probably a more involved fix required here but if you feel like editing this temporarily or maybe pulling the namespace flag and inserting that, you can probably get this working until there is a fix.

@dcarrolloreilly
Copy link

dcarrolloreilly commented Aug 12, 2024

I have submitted PR #319 to fix this. The issue I believe is context is being overwritten within a loop and not reset.

@jainpratik163
Copy link

facing the same issue .. when we are getting fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants