fix: fixed styling

dereekb · Mar 2, 2023 · 1e409fa · 1e409fa
1 parent b657cc9
commit 1e409fa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/packages/dbx-form/src/lib/formly/field/selection/selection.field.ts b/packages/dbx-form/src/lib/formly/field/selection/selection.field.ts
@@ -1,12 +1,10 @@
 import { asObservable, ObservableOrValue } from '@dereekb/rxjs';
-import { Maybe } from '@dereekb/util';
+import { LabeledValue, Maybe } from '@dereekb/util';
 import { FormlyFieldConfig } from '@ngx-formly/core';
 import { map } from 'rxjs';
 import { DescriptionFieldConfig, formlyField, LabeledFieldConfig, MaterialFormFieldConfig, propsAndConfigForFieldConfig } from '../field';
 
-export interface ValueSelectionOptionWithValue<T> {
-  value: T;
-  label: string;
+export interface ValueSelectionOptionWithValue<T> extends LabeledValue<T> {
   disabled?: boolean;
 }
 

diff --git a/packages/dbx-web/src/lib/layout/section/_section.scss b/packages/dbx-web/src/lib/layout/section/_section.scss
@@ -103,17 +103,13 @@ $header-left-reserved-space-small-screen: 120px;
       @include theming.nested-content-height(1); // always take up the height
     }
 
-    &.dbx-section-page-scroll-header {
+    &.dbx-section-page-scroll-locked {
       overflow: hidden;
-
-      .dbx-section-page-content {
-        padding-top: $header-bottom-margin;
-        overflow: auto;
-      }
     }
 
-    &.dbx-section-page-scroll-locked {
-      overflow: hidden;
+    &.dbx-section-page-scroll-body > .dbx-section-page-content {
+      overflow-y: auto; // content can scroll on y axis
+      overflow-x: hidden;
     }
 
     .dbx-section-page {