fix: removed browserModule imports from dbx-web

dereekb · Jan 30, 2022 · 84cbdf2 · 84cbdf2
1 parent 98c1d80
commit 84cbdf2
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/packages/dbx-web/src/index.ts b/packages/dbx-web/src/index.ts
@@ -1,2 +1 @@
 export * from './lib';
-export * from './lib/dbx-web.module';
diff --git a/packages/dbx-web/src/lib/button/button.module.ts b/packages/dbx-web/src/lib/button/button.module.ts
@@ -4,11 +4,11 @@ import { MatButtonModule } from '@angular/material/button';
 import { MatProgressButtonsModule } from 'mat-progress-buttons';
 import { DbNgxButtonComponent } from './button.component';
 import { DbNgxButtonSpacerComponent } from './button.spacer.component';
-import { BrowserModule } from '@angular/platform-browser';
+import { CommonModule } from '@angular/common';
 
 @NgModule({
   imports: [
-    BrowserModule,
+    CommonModule,
     MatIconModule,
     MatButtonModule,
     MatProgressButtonsModule

diff --git a/packages/dbx-web/src/lib/dbx-web.module.ts b/packages/dbx-web/src/lib/dbx-web.module.ts
@@ -1,5 +1,4 @@
 import { DbNgxLoadingModule } from './loading/loading.module';
-import { BrowserModule } from '@angular/platform-browser';
 import { MatProgressButtonsModule } from 'mat-progress-buttons';
 import { NgModule } from '@angular/core';
 import { DbNgxButtonModule } from './button';
@@ -14,14 +13,15 @@ import { DbNgxActionModule } from './action';
 })
 export class DbNgxWebModule { }
 
+/**
+ * Should only be imported once in the root app.
+ * 
+ * Pre-configures the following modules:
+ * - MatProgressButtonsModule
+ */
 @NgModule({
   imports: [
-    BrowserModule,
-    DbNgxWebModule,
     MatProgressButtonsModule.forRoot()
-  ],
-  exports: [
-    DbNgxWebModule
   ]
 })
-export class DbNgxSharedWebModule { }
+export class DbNgxWebRootModule { }
diff --git a/packages/dbx-web/src/lib/index.ts b/packages/dbx-web/src/lib/index.ts
@@ -7,3 +7,4 @@ export * from './loading';
 export * from './layout';
 export * from './router';
 export * from './text';
+export * from './dbx-web.module';
diff --git a/packages/dbx-web/src/lib/loading/loading.module.ts b/packages/dbx-web/src/lib/loading/loading.module.ts
@@ -1,15 +1,15 @@
+import { CommonModule } from '@angular/common';
 import { NgModule } from '@angular/core';
 import { DbNgxBasicLoadingComponent } from './basic-loading.component';
 import { DbNgxLoadingProgressComponent } from './loading-progress.component';
 import { MatProgressBarModule } from '@angular/material/progress-bar';
 import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
 import { DbNgxLoadingComponent } from './loading.component';
-import { BrowserModule } from '@angular/platform-browser';
 import { DbNgxReadableErrorModule } from '../error';
 
 @NgModule({
   imports: [
-    BrowserModule,
+    CommonModule,
     DbNgxReadableErrorModule,
     MatProgressSpinnerModule,
     MatProgressBarModule
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		export * from './lib';
		export * from './lib/dbx-web.module';