refactor: removed unnecessary forRoot module declarations

dereekb · Mar 25, 2022 · a8f850e · a8f850e
1 parent f694f86
commit a8f850e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 27 deletions.
diff --git a/packages/dbx-web/src/lib/interaction/popover/popover.coordinator.service.ts b/packages/dbx-web/src/lib/interaction/popover/popover.coordinator.service.ts
@@ -5,7 +5,9 @@ import { BehaviorSubject } from 'rxjs';
 /**
  * Used for coordinating popovers and closing/replacing existing ones when a new popover of the same name appears.
  */
-@Injectable()
+@Injectable({
+  providedIn: 'root'
+})
 export class DbxPopoverCoordinatorService {
 
   private _popovers = new BehaviorSubject<Map<DbxPopoverKey, DbxPopoverController>>(new Map());

diff --git a/packages/dbx-web/src/lib/interaction/popover/popover.module.ts b/packages/dbx-web/src/lib/interaction/popover/popover.module.ts
@@ -10,7 +10,6 @@ import { DbxPopoverService } from './popover.service';
 import { DbxPopoverContentComponent } from './popover.content.component';
 import { DbxPopoverComponent } from './popover.component';
 import { DbxPopoverControlsDirective } from './popover.controls.directive';
-import { DbxPopoverCoordinatorService } from './popover.coordinator.service';
 import { DbxPopoverHeaderComponent } from './popover.header.component';
 import { DbxPopoverScrollContentComponent } from './popover.scroll.content.component';
 import { DbxActionPopoverDirective } from './popover.action.directive';
@@ -56,15 +55,4 @@ import { DbxStyleLayoutModule } from '../../layout/style/style.layout.module';
     DbxPopoverService
   ]
 })
-export class DbxPopoverInteractionModule {
-
-  static forRoot(): ModuleWithProviders<DbxPopoverInteractionModule> {
-    return {
-      ngModule: DbxPopoverInteractionModule,
-      providers: [
-        DbxPopoverCoordinatorService
-      ]
-    };
-  }
-
-}
+export class DbxPopoverInteractionModule { }
diff --git a/packages/dbx-web/src/lib/interaction/popup/popup.coordinator.service.ts b/packages/dbx-web/src/lib/interaction/popup/popup.coordinator.service.ts
@@ -5,7 +5,9 @@ import { BehaviorSubject } from 'rxjs';
 /**
  * Used for coordinating popups and closing/replacing existing ones when a new popup of the same name appears.
  */
-@Injectable()
+@Injectable({
+  providedIn: 'root'
+})
 export class DbxPopupCoordinatorService {
 
   private _popups = new BehaviorSubject<Map<DbxPopupKey, DbxPopupController>>(new Map());

diff --git a/packages/dbx-web/src/lib/interaction/popup/popup.module.ts b/packages/dbx-web/src/lib/interaction/popup/popup.module.ts
@@ -44,15 +44,4 @@ import { DbxStyleLayoutModule } from '../../layout/style/style.layout.module';
     DbxPopupService
   ]
 })
-export class DbxPopupInteractionModule {
-
-  static forRoot(): ModuleWithProviders<DbxPopupInteractionModule> {
-    return {
-      ngModule: DbxPopupInteractionModule,
-      providers: [
-        DbxPopupCoordinatorService
-      ]
-    };
-  }
-
-}
+export class DbxPopupInteractionModule {}