Skip to content

Commit

Permalink
fix: setup project template replacement fixes
Browse files Browse the repository at this point in the history
- fixed issue where ports were not replaced in wait-for-ports.sh
- fixed issue where ANGULAR_APP_NAME was not being replaced in downloaded files
  • Loading branch information
dereekb committed May 29, 2022
1 parent 4ab7a74 commit fbe36cf
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions setup/setup-project.sh
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ rm test-$API_APP_NAME.sh.tmp
chmod +x test-$API_APP_NAME.sh

curl https://raw.githubusercontent.com/dereekb/dbx-components/$SOURCE_BRANCH/wait-for-ports.sh -o wait-for-ports.sh.tmp
sed -e "s/demo/$ANGULAR_APP_NAME/g" wait-for-ports.sh.tmp > wait-for-ports.sh
sed -e "s/9100-9106/$FIREBASE_EMULATOR_PORT_RANGE/g" wait-for-ports.sh.tmp > wait-for-ports.sh
rm wait-for-ports.sh.tmp
chmod +x wait-for-ports.sh

Expand Down Expand Up @@ -404,7 +404,7 @@ download_ts_file () {
local FILE_PATH=$3
local FULL_FILE_PATH=$TARGET_FOLDER/$FILE_PATH
curl $DOWNLOAD_PATH/$FILE_PATH -o $FULL_FILE_PATH.tmp
sed -e "s:APP_CODE_PREFIX_UPPER:$APP_CODE_PREFIX_UPPER:g" -e "s:APP_CODE_PREFIX_LOWER:$APP_CODE_PREFIX_LOWER:g" -e "s:APP_CODE_PREFIX:$APP_CODE_PREFIX:g" -e "s:FIREBASE_COMPONENTS_NAME:$FIREBASE_COMPONENTS_NAME:g" -e "s:ANGULAR_COMPONENTS_NAME:$ANGULAR_COMPONENTS_NAME:g" $FULL_FILE_PATH.tmp > $FULL_FILE_PATH
sed -e "s:APP_CODE_PREFIX_UPPER:$APP_CODE_PREFIX_UPPER:g" -e "s:APP_CODE_PREFIX_LOWER:$APP_CODE_PREFIX_LOWER:g" -e "s:APP_CODE_PREFIX:$APP_CODE_PREFIX:g" -e "s:FIREBASE_COMPONENTS_NAME:$FIREBASE_COMPONENTS_NAME:g" -e "s:ANGULAR_COMPONENTS_NAME:$ANGULAR_COMPONENTS_NAME:g" -e "s:ANGULAR_APP_NAME:$ANGULAR_APP_NAME:g" $FULL_FILE_PATH.tmp > $FULL_FILE_PATH
rm $FULL_FILE_PATH.tmp
}

Expand Down

0 comments on commit fbe36cf

Please sign in to comment.