Style ESV integration #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenElgar
reviewed
Oct 15, 2021
BenElgar
reviewed
Oct 15, 2021
| return; | ||
| } | ||
| // Handle external routes (open in new tab). | ||
| window.open(href, '_blank')?.focus(); |
There was a problem hiding this comment.
Nbd but I'd prefer if external links were actually anchor tags, styled to look like buttons rather than using JS. That way the user can know what will happen before they click on the link.
BenElgar
reviewed
Oct 15, 2021
|
No review needed from me, Ben is on it :) One small suggestion: In a few places where we write "Vault" and there is adequate space (like the main page header for "Add Vault") we should be a tiny bit more verbose/explicit and call it a "Secrets Vault" for clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves styling & layout in ESV integration UI.
Also makes small improvements to
CheckeredTablestyling and addshrefhandling to<Button />for both internal and external routes.