Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3675 / Demo ctrader design updates #14398

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Updated demo ctrader design according to figma updates

Screenshots:

image image image

image

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 1, 2024 7:53am

Copy link
Contributor

github-actions bot commented Mar 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14398](https://github.com/binary-com/deriv-app/pull/14398)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3675-demo-ctrader-d-14e1c4.binary.sx?qa_server=red.derivws.com&app_id=24036
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3675-demo-ctrader-d-14e1c4.binary.sx
- **App ID**: `24036`

Copy link
Contributor

github-actions bot commented Mar 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3675-demo-ctrader-d-14e1c4.binary.sx/

heorhi-deriv
heorhi-deriv previously approved these changes Mar 29, 2024
nijil-deriv
nijil-deriv previously approved these changes Mar 29, 2024
@coveralls
Copy link

coveralls commented Apr 1, 2024

Coverage Status

coverage: 39.515% (-0.01%) from 39.527%
when pulling 27e2c8b on lubega-deriv:WALL-3675/demo-ctrader-design-updates
into 6ff7b26 on binary-com:master.

Copy link

sonarqubecloud bot commented Apr 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Apr 1, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 9c25063 into deriv-com:master Apr 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants