Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3722 / CFD modal button size #14513

Merged

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Updated button size in CFD modals to match figma design

Screenshots:

Screenshot 2024-04-05 at 10 30 58 AM Screenshot 2024-04-05 at 10 32 39 AM

Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 5, 2024 3:59am

Copy link
Contributor

github-actions bot commented Apr 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14513](https://github.com/binary-com/deriv-app/pull/14513)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3722-cfd-modal-button-size.binary.sx?qa_server=red.derivws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3722-cfd-modal-button-size.binary.sx
- **App ID**: `24061`

Copy link
Contributor

github-actions bot commented Apr 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3722-cfd-modal-button-size.binary.sx/

Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 39.932% (-0.01%) from 39.946%
when pulling 3279d2a on lubega-deriv:WALL-3722/cfd-modal-button-size
into 35f5980 on binary-com:master.

@nijil-deriv nijil-deriv merged commit b43d717 into deriv-com:master Apr 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants