Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akmal / fix: do not reset local storage at every guide step #17848

Conversation

akmal-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ❌ Failed (Inspect) Dec 18, 2024 6:49am

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17848](https://github.com/deriv-com/deriv-app/pull/17848)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-b-localstorage-issue.binary.sx?qa_server=red.derivws.com&app_id=24183
    - **Original**: https://deriv-app-git-fork-akmal-deriv-b-localstorage-issue.binary.sx
- **App ID**: `24183`

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🟧 Performance 76
🟢 Accessibility 96
🟢 Best practices 100
🟧 SEO 67
🔺 PWA 33

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-b-localstorage-issue.binary.sx/

Copy link
Contributor

Generating Lighthouse report...

@akmal-deriv akmal-deriv merged commit 1f1627d into deriv-com:feature/dtrader-guides-improvements Dec 18, 2024
3 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant