-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH] shontzu/TRAH-5356/fe-implementation-api-group-cleanup #17999
Open
shontzu-deriv
wants to merge
6
commits into
deriv-com:master
Choose a base branch
from
shontzu-deriv:shontzu/TRAH-5356/fe-implementation-api-group-cleanup
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[TRAH] shontzu/TRAH-5356/fe-implementation-api-group-cleanup #17999
shontzu-deriv
wants to merge
6
commits into
deriv-com:master
from
shontzu-deriv:shontzu/TRAH-5356/fe-implementation-api-group-cleanup
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EU not limit to financial since trading insist DIEL financial has synthetics
shontzu-deriv
requested review from
heorhi-deriv,
jim-deriv,
nijil-deriv,
habib-deriv and
hirad-deriv
as code owners
January 17, 2025 08:42
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shontzu-deriv
commented
Jan 17, 2025
packages/cfd/src/Containers/cfd-compare-accounts/cfd-compare-accounts-title-icon.tsx
Show resolved
Hide resolved
shontzu-deriv
commented
Jan 17, 2025
shontzu-deriv
changed the title
Shontzu/trah 5356/fe implementation api group cleanup
[TRAH] shontzu/TRAH-5356/fe-implementation-api-group-cleanup
Jan 17, 2025
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-trah-5356fe-imp-e9c66b.binary.sx/ |
aizad-deriv
approved these changes
Jan 17, 2025
lubega-deriv
approved these changes
Jan 17, 2025
heorhi-deriv
approved these changes
Jan 17, 2025
jim-deriv
approved these changes
Jan 20, 2025
…ion-api-group-cleanup
…ion-api-group-cleanup
shontzu-deriv
had a problem deploying
to
Preview
January 22, 2025 02:31 — with
GitHub Actions
Failure
…ion-api-group-cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
EU no longer limited to financial products since trading team insisted DIEL financial should have synthetic instrument too
Before:
in EU, MT5 is shown as MT5
CFDs
with yellow variant iconAfter:
in EU, MT5
CFDs
should just show MT5Standard
with the regular blue iconNote to dev:
BE deployed in qa137
use
es
mf
account for EU tradershubuse
cz
mfw
for EU walletsScreenshots:
Tradershub fix:
Screen.Recording.2025-01-17.at.4.48.15.PM.mov
Wallets fix:
d06055d9-7229-4a56-a473-504d7aab728d.mov