Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lubega/TRAH: 5324/Change redirection for residence #18005

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Lubega/TRAH: 5324/Change redirection for residence #18005

merged 3 commits into from
Jan 22, 2025

Conversation

habib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

suisin-deriv and others added 2 commits January 20, 2025 13:27
@suisin-deriv
[TRAH5324] Suisin/chore: fix to not check citizen and check residence…
d7e88cd 
… instead (#17986)

* chore: fix to not check citizen and check residence instead

* chore: change hooks to only contain isHubRedirectionEnabled
@lubega-deriv
fix: check redirection based on authorize country (#18004)
967475c
@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 20, 2025 9:28am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions GitHub Actions
Copy link
Contributor

package old new diff pct change
account 274 KB 274 KB 0 B 0% 🟢
appstore 260 KB 260 KB 0 B 0% 🟢
bot-web-ui 775 KB 775 KB 0 B 0% 🟢
cashier 561 KB 561 KB 0 B 0% 🟢
cfd 119 KB 119 KB 0 B 0% 🟢
core 8.5 MB 8.5 MB --152 B −-0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 58 KB 58 KB 0 B 0% 🟢
trader 572 KB 572 KB 0 B 0% 🟢
wallets 850 KB 850 KB 0 B 0% 🟢

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/18005](https://github.com/deriv-com/deriv-app/pull/18005)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-change-redirection-for-residence.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-change-redirection-for-residence.binary.sx
- **App ID**: `23848`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 20, 2025 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-change-redirection-for-residence.binary.sx/

@lubega-deriv
Change redirection for residence (#18006)
24fb835 
* fix: check redirection based on authorize country

* fix: remove trading_hub
@github-actions GitHub Actions
Copy link
Contributor

package old new diff pct change
account 274 KB 274 KB 0 B 0% 🟢
appstore 260 KB 260 KB 0 B 0% 🟢
bot-web-ui 775 KB 775 KB 0 B 0% 🟢
cashier 561 KB 561 KB 0 B 0% 🟢
cfd 119 KB 119 KB 0 B 0% 🟢
core 8.5 MB 8.5 MB --242 B −-0.0% 🟢
p2p 1.0 MB 1.0 MB 0 B 0% 🟢
reports 58 KB 58 KB 0 B 0% 🟢
trader 572 KB 572 KB 0 B 0% 🟢
wallets 850 KB 850 KB --14 B −-0.0% 🟢

@habib-deriv habib-deriv merged commit 927cb7d into master Jan 22, 2025
15 checks passed
@habib-deriv habib-deriv deleted the change-redirection-for-residence branch January 22, 2025 06:03
rupato-deriv pushed a commit that referenced this pull request Jan 22, 2025
@habib-deriv @suisin-deriv
@lubega-deriv @rupato-deriv
Lubega/TRAH: 5324/Change redirection for residence (#18005)
021edab 
* [TRAH5324] Suisin/chore: fix to not check citizen and check residence instead (#17986)

* chore: fix to not check citizen and check residence instead

* chore: change hooks to only contain isHubRedirectionEnabled

* fix: check redirection based on authorize country (#18004)

* Change redirection for residence (#18006)

* fix: check redirection based on authorize country

* fix: remove trading_hub

---------

Co-authored-by: Sui Sin <[email protected]>
Co-authored-by: lubega-deriv <[email protected]>
heorhi-deriv added a commit that referenced this pull request Jan 22, 2025
@heorhi-deriv
Revert "Lubega/TRAH: 5324/Change redirection for residence (#18005)"
f53556d 
This reverts commit 927cb7d.
@heorhi-deriv heorhi-deriv mentioned this pull request Jan 22, 2025
Merged
heorhi-deriv added a commit that referenced this pull request Jan 22, 2025
@heorhi-deriv
Revert "Lubega/TRAH: 5324/Change redirection for residence (#18005)" (#…
358ea63 
…18015)

This reverts commit 927cb7d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv heorhi-deriv is a code owner

@jim-deriv jim-deriv Awaiting requested review from jim-deriv jim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@habib-deriv @suisin-deriv @lubega-deriv