Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add signup flow #115

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

thisyahlen-deriv
Copy link
Contributor

No description provided.

@thisyahlen-deriv thisyahlen-deriv marked this pull request as draft April 19, 2024 02:17
Copy link

Preview Link: https://pr-115.traders-hub.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8795295558

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 36 of 79 (45.57%) changed or added relevant lines in 14 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 48.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/flows/Signup/PasswordSettingModal/PasswordSettingModal.tsx 4 8 50.0%
src/flows/Signup/SignupScreens/SignupScreens.tsx 3 7 42.86%
src/flows/Signup/SignupWrapper/SignupWrapper.tsx 7 14 50.0%
src/flows/Signup/CitizenshipModal/CitizenshipModal.tsx 7 20 35.0%
src/hooks/useNewVirtualAccount.ts 6 21 28.57%
Files with Coverage Reduction New Missed Lines %
src/cfd/modals/MT5PasswordModal/MT5Success.tsx 5 15.79%
Totals Coverage Status
Change from base Build 8793701094: -0.5%
Covered Lines: 1387
Relevant Lines: 2321

💛 - Coveralls

@thisyahlen-deriv thisyahlen-deriv marked this pull request as ready for review April 23, 2024 05:55
@thisyahlen-deriv thisyahlen-deriv self-assigned this Apr 23, 2024
@habib-deriv habib-deriv merged commit eeb23a3 into deriv-com:main Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants