Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH] Hasan/TRAH-2669/Mt5 success modal content update #119

Merged
merged 8 commits into from
Apr 23, 2024

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Apr 22, 2024

Changes:

Update the content of the MT5 success modal to match with production.

@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8794284114

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 38 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.1%) to 48.986%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/cfd/modals/MT5PasswordModal/MT5Success.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/cfd/modals/TradeModal/TradeModal.tsx 4 23.53%
src/cfd/screens/TradeScreen/TradeLink/TradeLink.tsx 9 8.7%
src/cfd/screens/TradeScreen/TradeScreen.tsx 11 14.29%
src/cfd/constants/constants.tsx 14 50.88%
Totals Coverage Status
Change from base Build 8780163935: -1.1%
Covered Lines: 1342
Relevant Lines: 2231

💛 - Coveralls

@hasan-deriv hasan-deriv changed the title chore: updated certificate [TRAH] Hasan/TRAH-2669/Mt5 success modal content update Apr 23, 2024
@hasan-deriv hasan-deriv marked this pull request as ready for review April 23, 2024 02:55
Copy link

Preview Link: https://pr-119.traders-hub.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@thisyahlen-deriv thisyahlen-deriv merged commit 4b3b3ec into deriv-com:main Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants