Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4883 - examples: fix condition #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#4883 - examples: fix condition #3

wants to merge 2 commits into from

Conversation

deshanm
Copy link
Owner

@deshanm deshanm commented May 5, 2022

https://github.com/expressjs/express/pull/4883/files

Note:

  • Since this is an issue in if-condition, it cannot identify by the typescript. We need to use eslint to identify it

image

@deshanm deshanm added ts-failed conditional-error if conditions, else, switch labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
conditional-error if conditions, else, switch ts-failed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deshanm