Jupyterlab 4 upgrade #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peytondmurray
force-pushed
the
jupyterlab-4-upgrade
branch
from
f62cbb7 to
26c4285
Compare
mlucool
reviewed
Apr 3, 2023
peytondmurray
force-pushed
the
jupyterlab-4-upgrade
branch
from
26c4285 to
ae2445f
Compare
|
Thanks for the input - the changes you asked for have been implemented. I'll rerequest review - can you make sure the |
peytondmurray
force-pushed
the
jupyterlab-4-upgrade
branch
from
ae2445f to
645d95c
Compare
mlucool
reviewed
Apr 4, 2023
peytondmurray
force-pushed
the
jupyterlab-4-upgrade
branch
from
645d95c to
e37b495
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the extension to JupyterLab 4, updates dependencies to their latest version (except for the ones that are shared/constrained by JupyterLab itself, which are matched to https://github.com/jupyterlab/jupyterlab/blob/master/package.json)
Here's a screenshot of the extension working with
jupyterlab==4.0.0a37. I tried changing the output truncation limits and everything seemed okay.The only possible issue I saw was a few warnings in the browser console about something related to
notebooklspadapter.ts, which I don't think is related.