-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare v7.2.0 #1345
chore: prepare v7.2.0 #1345
Conversation
WalkthroughThe updates encompass a new version release (7.1.0) that includes dependency upgrades for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant UpgradeManager
User->>App: Initiate Upgrade
App->>UpgradeManager: Process Upgrade v720
UpgradeManager->>App: Execute Upgrade Logic
App->>User: Confirm Upgrade Completion
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- app/upgrades.go (1 hunks)
- app/upgrades/v720/upgrade.go (1 hunks)
Additional comments not posted (9)
app/upgrades.go (2)
6-6
: Import addition looks good.The import for
v720
is consistent with existing imports for previous versions.
13-13
: Registration of v720 upgrade handler is correct.The addition of the
v720
upgrade handler follows the same pattern as previous versions, ensuring consistency.app/upgrades/v720/upgrade.go (7)
1-10
: File structure and imports are appropriate.The file is well-organized, and the necessary imports are included.
12-14
: Interface implementation is correct.The
Upgrade
struct correctly implements theupgrades.Upgrade
interface.
16-20
: Struct definition is clear and concise.The
Upgrade
struct is defined with the necessary fields for module management and configuration.
22-28
: Constructor function is well-implemented.
NewUpgrade
function correctly initializes and returns anUpgrade
instance.
30-33
: Upgrade name is correctly set.The
Name
method returns the expected version string for the upgrade.
35-41
: Handler function is implemented correctly.The
Handler
method returns an upgrade handler that runs migrations without requiring additional logic, which is appropriate for this upgrade.
43-46
: Store upgrades method is correctly implemented.The
StoreUpgrades
method returns an emptyStoreUpgrades
struct, indicating no store changes are needed.
## Version 7.1.0 | ||
### Dependencies | ||
- ([\#1323](https://github.com/desmos-labs/desmos/pull/1343)) Bumped `cosmos-sdk` to `v0.47.13` | ||
- ([\#1324](https://github.com/desmos-labs/desmos/pull/1344)) Bumped `wasmvm` to `v1.5.3` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate entry in dependencies section.
There is a duplicate entry for the cosmos-sdk
version bump. Ensure this is intentional or remove the duplicate.
👀 Docs preview available here: https://66b4b1ada5620fef5123ab26--desmos-docs.netlify.app |
6a39388
to
d9b8d8a
Compare
Description
Closes: #XXXX
This PR prepares v7.2.0 including dependencies updates.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeSummary by CodeRabbit