Split profiles keeper #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 67 73 +6
Lines 3456 3456
=======================================
Hits 2493 2493
Misses 864 864
Partials 99 99
Continue to review full report at Codecov.
|
renamed file
RiccardoM
reviewed
May 26, 2021
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
| - Standardized `PostID` naming convetions ([#419](https://github.com/desmos-labs/desmos/issues/419)) | |||
| - Renamed all events `Attribute` into `AttributeKey` ([#423](https://github.com/desmos-labs/desmos/issues/423)) | |||
| - Updated Cosmos to `v0.42.5` ([#433](https://github.com/desmos-labs/desmos/issues/433)) | |||
| - Split the `Profiles` `keeper`, `msg_server` in multiple files according to their purpose ([#430](https://github.com/desmos-labs/desmos/issues/430)) | |||
There was a problem hiding this comment.
I don't think we should include code-cleanliness related changes inside the CHANGELOG
@RiccardoM It was already splitted |
RiccardoM
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR split the
x/profileskeeper in multiple files handles different kind of operations to improve maintainability.Closes #430 .
Checklist
CHANGELOG.mdfile.Files changedin the Github PR explorer.